Add changelog-existence workflow #7
Conversation
| @@ -0,0 +1,106 @@ | |||
| # **what?** | |||
There was a problem hiding this comment.
This should go into a README
| type: string | ||
| required: true | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Should this be a composite action instead of a workflow? Can you show an example how it would be used, or open a PR in another repo showing that?
| comment-author: 'github-actions[bot]' | ||
| body-includes: ${{ inputs.changelog_comment }} | ||
|
|
||
| - name: Set if comment already exists |
There was a problem hiding this comment.
Is this step necessary? Looks like it maps the output of the previous step into a different name.
| if: | | ||
| steps.changelog_check.outputs.exists == 'false' && | ||
| steps.comment_check.outputs.exists == 'false' | ||
| uses: peter-evans/create-or-update-comment@v1 |
There was a problem hiding this comment.
Does this work on PRs from forks?
| # changelog: | ||
| # uses: dbt-labs/actions/.github/workflows/changelog-check.yml@main | ||
| # with: | ||
| # changelog_comment: 'Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see [the contributing guide](https://github.com/dbt-labs/dbt-core/blob/main/CONTRIBUTING.md#adding-changelog-entry).' |
There was a problem hiding this comment.
So this requires installing yet another program. This increases the learning curve for new contributors. There should at least be a setting to make this optional and not fail the pipeline.
Are there alternatives? Github can automatically generate a change log when creating a new release: https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes Can you see how it compares to changie?
Within dbt-trino we are using
changieto create changelog entries.changieoffers following features:changie newwith configurable entries.See https://changie.dev/
We would like to do the same for trino-python-client and eventually trino.