Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow JUnit assertions #267

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Disallow JUnit assertions #267

merged 1 commit into from
Feb 29, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Feb 29, 2024

No description provided.

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Feb 29, 2024
@cla-bot cla-bot bot added the cla-signed label Feb 29, 2024
@ebyhr ebyhr requested a review from wendigo February 29, 2024 00:31
mosabua
mosabua reviewed Feb 29, 2024
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principal I think this is great. Just have to look at impl and refine a bit maybe.

mosabua
mosabua approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets ship this, probably worth adding to trino some time

@ebyhr ebyhr merged commit 43c8142 into trinodb:main Feb 29, 2024
2 checks passed
@ebyhr ebyhr deleted the ebi/junit-ban branch February 29, 2024 01:48
@github-actions github-actions bot added this to the 7 milestone Feb 29, 2024
@mosabua mosabua mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua approved these changes

@wendigo wendigo Awaiting requested review from wendigo

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Milestone
7
Development

Successfully merging this pull request may close these issues.
2 participants
@ebyhr @mosabua