Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge yml files into docker-compose.yml #273

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Merge yml files into docker-compose.yml #273

merged 1 commit into from
Mar 6, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Mar 5, 2024

No need to separate yml file because they're not reused. We had to jump other files to confirm the service definition.

@cla-bot cla-bot bot added the cla-signed label Mar 5, 2024
@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Mar 5, 2024
@ebyhr ebyhr requested review from mosabua and willmostly March 6, 2024 00:07
Copy link
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for also updating the docs.

@ebyhr ebyhr merged commit 2717e47 into trinodb:main Mar 6, 2024
2 checks passed
@ebyhr ebyhr deleted the ebi/docker-merge branch March 6, 2024 21:12
@github-actions github-actions bot added this to the 7 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants