Make startup command configurable #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
reviewed
Oct 2, 2024
willmostly
changed the title
willmostly
force-pushed
the
will/helm-jvm-opts
branch
from
e0f8f4f to
9f684c1
Compare
mosabua
reviewed
Oct 3, 2024
|
If we go with this approach where the whole command is configurable.. which is fine by me .. we should update commit message, PR name, release notes suggestion, and also add relevant info to the docs. |
mosabua
requested changes
Oct 3, 2024
willmostly
force-pushed
the
will/helm-jvm-opts
branch
from
9f684c1 to
9dc4bc1
Compare
willmostly
changed the title
willmostly
force-pushed
the
will/helm-jvm-opts
branch
from
f5f0ecc to
4b0d3ca
Compare
mosabua
requested changes
Oct 16, 2024
willmostly
force-pushed
the
will/helm-jvm-opts
branch
2 times, most recently
from
8624f4b to
bbe2c15
Compare
Co-authored-by: Manfred Moser <[email protected]>
mosabua
force-pushed
the
will/helm-jvm-opts
branch
from
bbe2c15 to
ad9f223
Compare
mosabua
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the startup command configurable
Additional context and related issues
This allows users to set java options such as
-Djavax.net.ssl.truststore=/path/to/truststore, run short scripts, and otherwise customize startup.Release notes
required.
Helm Chart
Make the startup command configurable