Update dependencies #610
Open
Update dependencies #610
+31
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oneonestar
force-pushed
the
star/updates-2025feb
branch
from
c39cdcd to
4a9f591
Compare
|
Not sure are there better way than this |
oneonestar
force-pushed
the
star/updates-2025feb
branch
from
4a9f591 to
a85e79a
Compare
mosabua
reviewed
Feb 5, 2025
| @@ -23,7 +23,7 @@ | |||
| import com.google.common.collect.ImmutableList; | |||
| import com.google.common.collect.ImmutableMap; | |||
| import com.google.common.collect.ImmutableSet; | |||
| import io.airlift.compress.zstd.ZstdDecompressor; | |||
| import io.airlift.compress.v3.zstd.ZstdDecompressor; | |||
There was a problem hiding this comment.
This will use the native compression implementations .. but I think it has to be packaged into the app somehow. @wendigo and @dain probably know more or you can try and find the Trino PR that upgraded to these and see what has to be done.
It might be that airlift handeles it all but we should confirm
There was a problem hiding this comment.
Looks like a trivial change.
trinodb/trino@6842df3#diff-fde1330f7f6c01cf08ffdc4d48e576c958a9d5b34b927b08f39cd59871feef16R46-R68
There was a problem hiding this comment.
Hm.. we should confirm that the native libraries are part of the tarball and docker container
There was a problem hiding this comment.
LGTM
➜ trino-gateway git:(star/updates-2025feb) jar tf gateway-ha/target/gateway-ha-14-SNAPSHOT-jar-with-dependencies.jar | grep 'aircompressor'
aircompressor/
aircompressor/linux-aarch64/
aircompressor/linux-aarch64/libbz2.so
aircompressor/linux-aarch64/liblz4.so
aircompressor/linux-aarch64/libsnappy.so
aircompressor/linux-aarch64/libzstd.so
aircompressor/linux-amd64/
aircompressor/linux-amd64/libbz2.so
aircompressor/linux-amd64/liblz4.so
aircompressor/linux-amd64/libsnappy.so
aircompressor/linux-amd64/libzstd.so
aircompressor/linux-ppc64le/
aircompressor/linux-ppc64le/libbz2.so
aircompressor/linux-ppc64le/liblz4.so
aircompressor/linux-ppc64le/libsnappy.so
aircompressor/linux-ppc64le/libzstd.so
aircompressor/macos-aarch64/
aircompressor/macos-aarch64/libbz2.dylib
aircompressor/macos-aarch64/liblz4.dylib
aircompressor/macos-aarch64/libsnappy.dylib
aircompressor/macos-aarch64/libzstd.dylib
aircompressor/macos-amd64/
aircompressor/macos-amd64/libbz2.dylib
aircompressor/macos-amd64/liblz4.dylib
aircompressor/macos-amd64/libsnappy.dylib
aircompressor/macos-amd64/libzstd.dylib
a85e79a to
0dc1767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update dependencies before release.
Additional context and related issues
MySQL performance problem has been resolved.
trinodb/trino#24809 (comment)
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.