support Geometry and Geography values as WKT strings #112
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
trino/trino.go
Outdated
| @@ -1469,7 +1469,7 @@ func (c *typeConverter) ConvertValue(v interface{}) (driver.Value, error) { | |||
| return nil, err | |||
| } | |||
| return vv.Bool, err | |||
| case "json", "char", "varchar", "varbinary", "interval year to month", "interval day to second", "decimal", "ipaddress", "uuid", "unknown": | |||
| case "json", "char", "varchar", "varbinary", "interval year to month", "interval day to second", "decimal", "ipaddress", "uuid", "SphericalGeography", "unknown": | |||
There was a problem hiding this comment.
Should we also add Geometry here?
There was a problem hiding this comment.
Yup, I can also add that
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
fengctor
changed the title
fengctor
force-pushed
the
support-geography-values
branch
from
9a6b25a to
5ea8daa
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
1 similar comment
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
fengctor
force-pushed
the
support-geography-values
branch
from
c32f937 to
18886b6
Compare
|
Hi @nineinchnick, it looks like I need help from someone with write access to get this merged. |
Allows us to use the WKT strings returned from Geometry and SphericalGeography expressions in queries like
select st_point(0, 0)andselect to_spherical_geography(st_point(0, 0))(both giving"Point (0 0)"). This would previously result in atype not supported: "SphericalGeography"error.