Allow OpenTelemetry instrumentation #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
commented
Oct 23, 2023
nineinchnick
force-pushed
the
otel-example
branch
from
d99bc2e to
a6d33de
Compare
nineinchnick
force-pushed
the
otel-example
branch
from
a6d33de to
f372b87
Compare
losipiuk
approved these changes
Apr 16, 2024
|
The docs include an example how to use OpenTelemetry, so it's important. Ignore the other commit that formats the README. |
losipiuk
reviewed
Apr 22, 2024
| otelClient := &http.Client{ | ||
| Transport: otelhttp.NewTransport(http.DefaultTransport), | ||
| } | ||
| trino.RegisterCustomClient("otel", otelClient) |
There was a problem hiding this comment.
It does, but the example above didn't check for it. I don't think error handling must be in every example, it would make it harder to read and since this is users code, we don't know a good way to handle errors anyway. Also, common Go linters detect unhandled errors.
losipiuk
approved these changes
Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass parent context to HTTP requests and document how to use the OTEL transport to make sure that traces are propagated. The OTEL transport will also create spans for all HTTP requests.
An alternative to #95.
Supersedes #92