Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stmtStats types #99

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Conversation

kamijin-fanta
Copy link
Contributor

Updated query statistic types with reference to the latest Trino sources. Some types are defined as int types and may overflow.

  • add field
    • runningPercentage
    • spilledBytes
    • peakMemoryBytes
    • physicalWrittenBytes
    • physicalInputBytes
    • elapsedTimeMillis
    • queuedTimeMillis
  • change int to int64
    • cpuTimeMillis
    • queuedTimeMillis
    • elapsedTimeMillis
    • processedRows
    • processedBytes

reference: https://github.com/trinodb/trino/blob/434/client/trino-client/src/main/java/io/trino/client/StatementStats.java

Copy link

cla-bot bot commented Dec 12, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick
Copy link
Member

@wendigo @losipiuk PTAL

@kamijin-fanta
Copy link
Contributor Author

Thanks for the quick review! I have sent the CLA PDF file via email.

@losipiuk
Copy link
Member

@cla-bot check

Copy link

cla-bot bot commented Dec 12, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Dec 12, 2023

The cla-bot has been summoned, and re-checked this pull request!

@wendigo
Copy link
Contributor

wendigo commented Dec 13, 2023

@cla-bot check

Copy link

cla-bot bot commented Dec 13, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Dec 13, 2023

The cla-bot has been summoned, and re-checked this pull request!

@kamijin-fanta
Copy link
Contributor Author

It looks like the name has been added to the CLA repository. Please let me know if I can help in any way.

trinodb/cla@bf4d8dc

@nineinchnick
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Dec 26, 2023
Copy link

cla-bot bot commented Dec 26, 2023

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr ebyhr force-pushed the stmtstats-type branch 2 times, most recently from a29782a to 02ac251 Compare February 17, 2024 02:14
@ebyhr
Copy link
Member

ebyhr commented Feb 17, 2024

CI with latest image is failing. master branch also faces the issue. #105

@wendigo
Copy link
Contributor

wendigo commented Feb 17, 2024

Fix for master: #106

@ebyhr ebyhr merged commit 7ac52e1 into trinodb:master Feb 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants