Add more guidelines #702
Merged
Add more guidelines #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
force-pushed
the
process
branch
4 times, most recently
from
60548ef to
069b162
Compare
losipiuk
reviewed
Sep 9, 2024
losipiuk
reviewed
Sep 9, 2024
losipiuk
reviewed
Sep 9, 2024
losipiuk
approved these changes
Sep 9, 2024
dain
approved these changes
Sep 24, 2024
Comment on lines
+134
to
+137
| Whenever in doubt on splitting a change into a separate commit, ask yourself the | ||
| following question: if all other work in the PR needs to be reverted after | ||
| merging to master for some objective reason, such as a bug has been discovered, | ||
| is it worth keeping that commit still in master. |
There was a problem hiding this comment.
The second sentence is a bit long maybe:
if all other work in the PR needs to be reverted for some reason (e.g., bugs), is it worth keeping that commit in master.
- For PR process, commit messages, and release notes - Moved from Trino codebase and wiki - Reworded to make them applicable to all trinodb projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also trinodb/trino#23201 for the original content.