Skip to content

Commit

Permalink
Improve exception logging when serializing invalid pages
Browse files Browse the repository at this point in the history
When a page has fewer channels then output columns, log the full stack
trace, and avoid producing an empty response. This makes debugging page
sources easier.
  • Loading branch information
nineinchnick authored and wendigo committed Oct 29, 2024
1 parent 812dc94 commit b81d357
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,9 @@ private List<Object> getRowValues()
List<Object> row = new ArrayList<>(columns.size());
for (OutputColumn outputColumn : columns) {
Type type = outputColumn.type();
Block block = currentPage.getBlock(outputColumn.sourcePageChannel());

try {
Block block = currentPage.getBlock(outputColumn.sourcePageChannel());
Object value = type.getObjectValue(session.toConnectorSession(), block, inPageIndex);
if (!supportsParametricDateTime) {
value = getLegacyValue(value, type);
Expand Down

0 comments on commit b81d357

Please sign in to comment.