Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11575 autopurge default #11730

Closed
wants to merge 3 commits into from

Conversation

sravanip09
Copy link
Contributor

Description

This is the continuation of effort done as part of #9457
Enabled hive.managed-table-auto-purge-default optional property at catalog level & will be enforced if auto_purge at table level is not set. This serves as default value for table property auto_purge & removes the
need to set auto_purge each and every time managed table is created. As mentioned in #11575 user is also seeing issue trino:> drop table withacid;
Query failed: The following metastore delete operations failed: drop table with acid
io.trino.spi.TrinoException: The following metastore delete operations failed: drop table withacid
This is happening as auto_purge is not set to true. hive.managed-table-auto-purge-default optional parameter gives flexibility to admin to enforce this at catalog level
there by apply to all the tables that will be created.

Is this change a fix, improvement, new feature, refactoring, or other?

This change is a improvement.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

This is a change to Hive connector

How would you describe this change to a non-technical end user or system administrator?

auto_purge = true allows to skip trash & speed up the dropping managed tables for hive connector. Current implementation requires user to specify the flag during the table creation. With this change
it gives the flexibility to set the auto_purge at catalog level.

Related issues, pull requests, and links

Related Issue: #11575
Related PR: #9457

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
() Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( x) No release notes entries required.
() Release notes entries required with the following suggested text:

@cla-bot
Copy link

cla-bot bot commented Mar 31, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: sparuc861.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@kokosing kokosing requested review from findepi and removed request for kokosing March 31, 2022 14:36
@sravanip09
Copy link
Contributor Author

Sorry i'm going to close this request and create a new one with cla approved ID.

@sravanip09 sravanip09 closed this Apr 1, 2022
@sravanip09 sravanip09 deleted the 11575_autopurge_default branch April 1, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant