Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix illegal reflective access in PointFileReaderWriterTest #4027

Conversation

ssoloff
Copy link
Member

@ssoloff ssoloff commented Sep 11, 2018

Overview

Addresses one item in #2796.

The illegal reflective access in PointFileReaderWriterTest was avoided by using an appropriately-configured mock of an interface instead of spying on a concrete class that implements that interface.

Functional Changes

None.

Manual Testing Performed

None.

@codecov-io
Copy link

Codecov Report

Merging #4027 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4027      +/-   ##
============================================
- Coverage     22.98%   22.95%   -0.03%     
+ Complexity     6138     6129       -9     
============================================
  Files           835      835              
  Lines         70913    70913              
  Branches      11466    11466              
============================================
- Hits          16301    16280      -21     
- Misses        52514    52536      +22     
+ Partials       2098     2097       -1
Impacted Files Coverage Δ Complexity Δ
...engine/framework/map/download/FileSizeWatcher.java 0% <0%> (-85.72%) 0% <0%> (-5%)
...gy/engine/framework/map/download/DownloadFile.java 36.95% <0%> (-15.22%) 9% <0%> (-2%)
.../games/strategy/engine/ClientFileSystemHelper.java 56.41% <0%> (-2.57%) 10% <0%> (-1%)
.../src/main/java/games/strategy/net/nio/Decoder.java 72.82% <0%> (-1.09%) 24% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb4a51...dc3fcf3. Read the comment docs.

@RoiEXLab RoiEXLab merged commit 4b76bd5 into triplea-game:master Sep 11, 2018
@ssoloff ssoloff deleted the issue-2796-fix-illegal-reflective-access-in-point-file-reader-writer-test branch September 11, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants