Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: removeComments from transpiled files #9

Merged
merged 2 commits into from
Sep 17, 2021
Merged

feat: removeComments from transpiled files #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a79c94
chore(tsconfig): set removeComments to true
trivikr Sep 17, 2021
ec10436
chore: add tsconfig.types.json to rmit only declaration
trivikr Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clients/client-s3/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"test": "yarn test:unit",
"build:cjs": "tsc -p tsconfig.json",
"build:es": "tsc -p tsconfig.es.json",
"build": "yarn build:cjs && yarn build:es",
"build:types": "tsc -p tsconfig.types.json",
"build": "yarn build:cjs && yarn build:es && yarn build:types",
"downlevel-dts": "downlevel-dts dist-types dist-types/ts3.4"
},
"main": "./dist-cjs/index.js",
Expand Down
2 changes: 0 additions & 2 deletions clients/client-s3/tsconfig.es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
"target": "es5",
"module": "esnext",
"moduleResolution": "node",
"declaration": true,
"declarationDir": "dist-types",
"lib": ["dom", "es5", "es2015.promise", "es2015.collection", "es2015.iterable", "es2015.symbol.wellknown"],
"outDir": "dist-es"
}
Expand Down
1 change: 1 addition & 0 deletions clients/client-s3/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"incremental": true,
"resolveJsonModule": true,
"esModuleInterop": true,
"removeComments": true,
"outDir": "dist-cjs",
"types": ["mocha", "node"]
},
Expand Down
10 changes: 10 additions & 0 deletions clients/client-s3/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"compilerOptions": {
"rootDir": "./src",
"esModuleInterop": true,
"declaration": true,
"declarationDir": "dist-types",
"emitDeclarationOnly": true
},
"exclude": ["test/**/*", "src/**/*.spec.ts"]
}