Small edits for JOSS review #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloede
reviewed
Dec 9, 2024
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
andrewwinters5000
approved these changes
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## paper-2024-joss #124 +/- ##
===================================================
- Coverage 75.83% 74.88% -0.95%
===================================================
Files 68 68
Lines 10568 10429 -139
Branches 2 2
===================================================
- Hits 8014 7810 -204
- Misses 2554 2619 +65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewwinters5000
merged commit 5f0c394
into
trixi-framework:paper-2024-joss
20 of 21 checks passed
|
@xuanxu Thanks a lot for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small edits on the paper file: spell out USA, format references and a typo.
Ref: openjournals/joss-reviews#7476