Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JOSS paper to README and add CITATION.cff #126

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

sloede
Copy link
Member

@sloede sloede commented Dec 11, 2024

In the README, I kept both the bibtex for the JOSS paper and the actual repo. However, this might be overkill, thus I'm happy to remove it if you think it is too much.

The citation file is copied from the JOSS review issue here.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.83%. Comparing base (1568fd3) to head (e4bf620).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   75.83%   75.83%           
=======================================
  Files          68       68           
  Lines       10568    10568           
  Branches        2        2           
=======================================
  Hits         8014     8014           
  Misses       2554     2554           
Flag Coverage Δ
unittests 75.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@DavidAKopriva DavidAKopriva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, too.

@sloede sloede merged commit b05419c into main Dec 11, 2024
21 checks passed
@sloede sloede deleted the msl/add-joss-paper branch December 11, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants