Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for CairoMakie to 0.13 for package docs, (keep existing compat) #2236

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the CairoMakie package from 0.6, 0.7, 0.8, 0.9, 0.10, 0.11 to 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.13 for package docs.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha ranocha force-pushed the compathelper/new_version/2025-01-15-00-06-08-265-00960691228 branch from 4df6791 to df8d198 Compare January 15, 2025 00:06
@sloede
Copy link
Member

sloede commented Jan 16, 2025

@ranocha Any reason not to merge this?

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version is not tested in CI. Please do not merge such updates where the new versions of the dependencies are not tested. For example, there was a breaking change affecting us in #2194

@ranocha ranocha changed the base branch from main to compathelper/new_version/2025-01-15-00-05-29-351-00716684826 January 27, 2025 08:24
@ranocha ranocha merged commit 2b60cb5 into compathelper/new_version/2025-01-15-00-05-29-351-00716684826 Jan 27, 2025
7 checks passed
@ranocha ranocha deleted the compathelper/new_version/2025-01-15-00-06-08-265-00960691228 branch January 27, 2025 08:24
ranocha added a commit that referenced this pull request Jan 28, 2025
…ting compat) (#2235)

* CompatHelper: bump compat for Makie in [weakdeps] to 0.22, (keep existing compat)

* CompatHelper: bump compat for CairoMakie to 0.13 for package docs, (keep existing compat) (#2236)

Co-authored-by: CompatHelper Julia <[email protected]>

* CompatHelper: bump compat for CairoMakie to 0.13 for package test, (keep existing compat) (#2237)

Co-authored-by: CompatHelper Julia <[email protected]>

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants