-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made easy support for providers with flaky/unreliable checkip servers #306
Comments
For 3., maybe see if throttled ipcheck servers return something else than a 200 or a 30x HTTP code, and in which case act accordingly (fallback to default server perhaps?) |
@RMerl ah, great idea! I was thinking about checking for timeout, but just tracking the HTTP return codes (maybe with a counter and threshold?) is quite a bit more obvious :) |
@themiron, did you get a particular HTTP response code when you were throttled in your test case? |
For 2 - currently get_address_backend() uses cmd, iface and remote in order, seems easy to add last resort with default ip checker. after that, same default server can be removed from plugins for simplicity |
ARAIR yes, something either 4xxx or 5xx, not really sure. |
So, code >=400 could be handled as a failure then. |
Agree to all above! Thank you guys for the awesome feedback :) |
already is |
Signed-off-by: Joachim Wiberg <[email protected]>
In #305 @themiron came up with the brilliant idea to simplify using another checkip server for providers with a flaky/unreliable service.
checkip-server=default
to tell inadyn to use its built-in default (ipify) instead of the provider provided oneThe text was updated successfully, but these errors were encountered: