dnspod plugin's bug

[jgh004]

When the A record is updated without sub_domain, the A record of the root domain name will be updated
For example, I want to update ddns.xxx.com
Actually it updated xxx.com
Forgive my bad english

[troglobit]

That plugin was submitted by @ysc3839, maybe he or someone else can give some input here.

[ysc3839]

Sorry, I'm not using dnspod now, and I'm not interesting in fixing this issue.
Maybe I will have a look when I have time.

[troglobit]

No problem, thanks for checking back! <3

Anyone else using dnspod can help out by reproducing the problem, locating their API documentation, and suggesting a fix.

[imess]

Looks like the sub_domain is missing from line 177 of plugins/dnspod.c,

login_token=%s%%2C%s&format=json&domain=%s&record_id=%d&record_line=%s&value=%s&sub_domain=%s

and line 179
domain, record_id, "%E9%BB%98%E8%AE%A4", alias->address, prefix);

try fixing it and compiling yourself

[troglobit]

Anyone had a chance to test this latest suggestion yet? Since I don't have dnspod myself I cannot test, and would likely risk breaking the plugin even further if I do the change speculatively.

A new release is coming soonish, so if someone can submit a pull request, or at least help out testing that would be much appreciated!

[troglobit]

OK, no response in this thread. I've added the suggested fix to the plugin in b6e7ea9. It's a speculative change and completely untested, but will at least be part of v2.9.0

[imess]

Sorry for the delay. I have been using this fix for over two months, it works flawlessly.

…

On Sun, Nov 21, 2021 at 8:36 PM Joachim Wiberg ***@***.***> wrote: OK, no response in this thread. I've added the suggested fix to the plugin in b6e7ea9 <b6e7ea9>. It's a speculative change and completely untested, but will at least be part of v2.9.0 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#352 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHQKNXQIOZD2GSPHDSCPKJDUNDRWTANCNFSM45RVISSQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[troglobit]

@imess OK, thanks! Let's hope I got it right ...