lib-v2: handle validation of ports for both v6 and v4 #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qubad786
approved these changes
Jan 13, 2025
ChapterSevenSeeds
pushed a commit
to ChapterSevenSeeds/apps
that referenced
this pull request
Jan 14, 2025
* better handling of ipv6 and wildcard addresses * update version * cleanup tests * greatly improve readability * update hashes * better check * flake * regen hashes
stavros-k
added a commit
that referenced
this pull request
Jan 27, 2025
* Added imaginary as an optional container * chore(deps): update alexta69/metube docker tag to v2025 (#1346) Co-authored-by: bugclerk <[email protected]> * chore(deps): update updates-patch-minor (#1345) Co-authored-by: bugclerk <[email protected]> * Publish new changes in catalog [skip ci] * Update catalog changes [skip ci] * chore(deps): update updates-patch-minor (#1352) Co-authored-by: bugclerk <[email protected]> * Publish new changes in catalog [skip ci] * Update catalog changes [skip ci] * lib-v2: handle validation of ports for both v6 and v4 (#1332) * better handling of ipv6 and wildcard addresses * update version * cleanup tests * greatly improve readability * update hashes * better check * flake * regen hashes * PR comments * Removed redunant line from description * dont nuke if users already have setup imaginary manually * fix metadata * simplify * use correct hash * fix rest of the tests * Update .gitignore * fix rendering * Update app.yaml --------- Co-authored-by: truenasbot <[email protected]> Co-authored-by: bugclerk <[email protected]> Co-authored-by: sonicaj <[email protected]> Co-authored-by: Stavros Kois <[email protected]> Co-authored-by: Stavros Kois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we always enable ipv6 for docker, we should also bind the wildcard ipv6 address.
Supersedes #1297
Closes #1296