apps: allow selecting host-ip for ports with new config format #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kmoore134
approved these changes
Jan 28, 2025
This was referenced Jan 28, 2025
|
@stavros-k can we pass the host ip as an env var using this variable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New apps and new ports on existing apps that added using the new config format, can now select ip to bind that port.
When 25.04 is released, migrations for existing apps/ports will follow.
Host IP features will also work on 24.10 as well.
For the apps/ports that need migration (that will come later), 25.04 will be required
Relates to #787, but not fully completes it yet.