Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: fix default ports #1517

Merged
merged 8 commits into from
Jan 31, 2025
Merged

apps: fix default ports #1517

merged 8 commits into from
Jan 31, 2025

Conversation

stavros-k
Copy link
Contributor

@stavros-k stavros-k commented Jan 31, 2025

Changed default ports to ensure unique default ports per app.
Added a basic script to check for duplicates and fail CI if found, which also gives the next 5 free ports

Closes #1512

Copy link

github-actions bot commented Jan 31, 2025

Stable

Diskoverdata

Affected areas: metadata, ui
Modified files:

  • app.yaml
  • questions.yaml

Home-Assistant

Affected areas: metadata, ui
Modified files:

  • app.yaml
  • questions.yaml

Prometheus

Affected areas: metadata, ui
Modified files:

  • app.yaml
  • questions.yaml

Notifying the following about changes to the trains:
@truenas/docs-team

@stavros-k stavros-k marked this pull request as ready for review January 31, 2025 15:28
Copy link

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listdir is painfully slow. scandir is the preferred method

@stavros-k stavros-k requested a review from yocalebo January 31, 2025 16:53
@stavros-k stavros-k merged commit 61946cc into master Jan 31, 2025
53 of 54 checks passed
@stavros-k stavros-k deleted the default-ports branch January 31, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefly III uses the same port as Plex by default
2 participants