Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Fixed broken web3 dependency #334

Closed
wants to merge 2 commits into from

Conversation

dylanseago
Copy link

@dylanseago dylanseago commented Jun 24, 2017

Upgraded web3 to ^0.19.1 and web3-provider-engine to ~13.0.0 to fix #332

Tests still need to be fixed.

@historiographist
Copy link

historiographist commented Jun 25, 2017

thanks for this, but it seems this is failing tests for a reason. even with these upgraded deps, i'm still getting errors when i run contracts, a la "TypeError: self.engine._fetchBlock is not a function" (as in the failed tests)

@dylanseago
Copy link
Author

@drkhaira Thanks for noting that. There are definitely things that need to be fixed to support the upgrade, this PR should just be used as a starting point for resolving the issues caused by web3/web3.js#904

@tcoulter
Copy link
Contributor

Hi there. Thanks for the PR.

This PR does two things: Upgrades web3 and upgrades the provider engine. Upgrading the provider engine should be a separate issue tackled at a separate time (although for the error you mentioned, bignumber.js, updating the provider engine might be required). I've updated web3 on the release branch of trufflesuite/ganache-core, which is now the core of the TestRPC. We'll update the provider engine in a future ticket.

Thanks!

@tcoulter tcoulter closed this Jul 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants