This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Pending transactions #227
Merged
Pending transactions #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasjpaterno
approved these changes
Nov 28, 2018
davidmurdoch
suggested changes
Jan 18, 2019
…e-core into pending-transactions
|
@davidmurdoch I have made all of the changes except the |
davidmurdoch
approved these changes
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eth_getTransactionByHash used to return null for pending transactions, but according to JSON RPC spec, if the transaction is pending only these fields should return null:
blockHash,blockNumber, andtransactionIndex. This PR fixes this bug so now we return the transaction object with the above mentioned fields as null for pending transactions. And for eth_getTransactionByReceipt on pending transactions, we return null.