Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Block num gt latest fix #228

Merged
merged 6 commits into from
Jan 18, 2019
Merged

Block num gt latest fix #228

merged 6 commits into from
Jan 18, 2019

Conversation

nicholasjpaterno
Copy link
Contributor

Resolves #108
This updates ganache to match geth and parity when block numbers exceed latest

The only conflict occurs in eth_getTransactionCount where I opted to match geth's behavior.

#parity
swirl eth_getTransactionCount 0x00a329c0648769a73afac7f9381e08fb43dbea72 0xfff
{"jsonrpc":"2.0","error":{"code":-32602,"message":"Unknown block number"},"id":120}

#GETH
swirl eth_getTransactionCount 0x00a329c0648769a73afac7f9381e08fb43dbea72 0xfff
{"jsonrpc":"2.0","id":120,"result":null}

Copy link
Member

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 Siskel and Ebert would probably give this PR Two Thumbs Up™

@davidmurdoch davidmurdoch merged commit 6c84bba into develop Jan 18, 2019
@davidmurdoch davidmurdoch deleted the block-num-gt-latest-fix branch January 18, 2019 22:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants