test: re-use static build directory for caching between test runs

[Zolmeister]

fixes trufflesuite/truffle#343

[Zolmeister]

@gnidan bump

[gnidan]

LGTM, although @tcoulter could you please also look? I am not sure if there are unknown unknowns here that would cause things to break.

[owocki]

hey @tcoulter sorry to be a pest, just wanted to let @Zolmeister know what they need to do to push this across the finish line.

[tcoulter]

Hi @Zolmeister, sorry for the late response.

Thanks for the submission. This isn't a bad solution, but may potentially be prone to artifact collision if developers have multiple Truffle projects on their machine that they're actively developing. Instead of using an operating-system level, static temp directory, can you refactor to use a temp directory local to the project? Make sure that the folder structure looks like this:

<project directory>
  -> .tmp/
    -> test/
      -> ... .json
      -> ... .json
      -> ... .json

When running your tests, it should use the artifacts in this directory (<project directory>/.tmp/test) if they exist. It should then compile contracts as necessary, even if the test artifacts exist (e.g., some source files may have been updated). Any output from compilation during testing should be written to to this directory.

Again, thanks for your work, and apologies for the late response. Really look forward to your solution!

[owocki]

hey @Zolmeister -- just making sure you saw the above ☝️

[Zolmeister]

@tcoulter updated

[owocki]

happy new year @tcoulter -- let us gitcoiners know if theres anything else we can do here :) cc @benjamincburns

[benjamincburns]

I pinged @gnidan and @tcoulter internally on this, and the consensus was that it looks good, but we might be waiting a bit to merge it, as we'll want it to go out with a major release.

[gnidan]

@Zolmeister Thank you for the work here! This all looks good. Our plan, like @benjamincburns said, is that this will go out with a major release.

In the meantime, @owocki could you please record this bounty as completed?

Thanks all!