Skip to content
This repository has been archived by the owner on Jun 14, 2018. It is now read-only.

merge config in develop #80

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

merge config in develop #80

wants to merge 1 commit into from

Conversation

miyao-gmo
Copy link

No description provided.

@miyao-gmo
Copy link
Author

trufflesuite/truffle#696

gnidan
gnidan suggested changes Feb 2, 2018
View reviewed changes
Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting changes for the spacing.

Besides that, could you please verify that this works as expected in the context of truffle test?

Thanks for the contribution! Will look to get this into the next release.

lib/environment.js Outdated
network_id: testrpcOptions.network_id,
provider: function() {
return new Web3.providers.HttpProvider(url);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Please conform to 2-space indents :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
I fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gnidan gnidan gnidan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miyao-gmo @gnidan