This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Lint Migrations.sol #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnidan
reviewed
Feb 12, 2018
|
|
||
| function upgrade(address new_address) restricted { | ||
| Migrations upgraded = Migrations(new_address); | ||
| upgraded.setCompleted(last_completed_migration); |
There was a problem hiding this comment.
Does solhint want 4-space indents?
There was a problem hiding this comment.
gnidan
approved these changes
Feb 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses truffle-migrate 19
Solhint warns about not locking the pragma. However a best-practices issue here arrived at the conclusion that libraries and platforms should not pin.
Adds
publicmodifier to everything including constructor. More on constructor visibility over at Solidity hereRemix warns that:
Probably fine for most people though :)