Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Add --show-events flag to test command #1232

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Conversation

xitter
Copy link
Contributor

@xitter xitter commented Aug 26, 2018

Issue #186

Referenced PR on archived repo trufflesuite/truffle-core#6

truffle test --show-events

@gnidan gnidan changed the base branch from develop to next August 27, 2018 19:09
@gnidan gnidan changed the base branch from next to develop August 27, 2018 19:10
@gnidan
Copy link
Contributor

gnidan commented Aug 27, 2018

Hey @xitter, thanks for this!

Could you also add this as an option to packages/truffle-core/lib/commands/test.js, in the builder property for the command? See this example for the compile command.

Just so it's slightly more explicit.

@@ -139,7 +139,7 @@ TestRunner.prototype.startTest = function(mocha, callback) {
TestRunner.prototype.endTest = function(mocha, callback) {
var self = this;

if (mocha.currentTest.state != "failed") {
if (mocha.currentTest.state != "failed" && !self.config["show-events"]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also probably want a comment here because it's not entirely clear.

@xitter
Copy link
Contributor Author

xitter commented Aug 28, 2018

@gnidan Added PR #1238 for adding this as an option in truffle-core.

@gnidan
Copy link
Contributor

gnidan commented Aug 28, 2018

Great, thanks! Merging.

@gnidan gnidan merged commit fff24be into trufflesuite:develop Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants