Fix Windows problems with packages and index.html. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedodd
reviewed
Oct 16, 2020
| @@ -109,9 +109,9 @@ impl HtmlPipeline { | |||
|
|
|||
| // Assemble a new output index.html file. | |||
| let output_html = target_html.html(); // TODO: prettify this output. | |||
| fs::write(format!("{}/index.html", self.cfg.dist.display()), output_html.as_bytes()) | |||
| fs::write(self.cfg.dist.join("index.html"), output_html.as_bytes()) | |||
There was a problem hiding this comment.
☠️ wow ... sorry @MartinKavik that's definitely my fault. Good find! Sorry about the trouble.
thedodd
reviewed
Oct 16, 2020
| .await | ||
| .context("error writing finalized HTML output")?; | ||
| .context("error writing finalized HTML output")?; // TODO: show also error details (in a verbose mode?) |
There was a problem hiding this comment.
This actually does surface the underlying error when it makes it up to the top-level of the app. It will print the context message first, and then will print out the chain of errors leading up to the context message.
There was a problem hiding this comment.
Unless you had something else in mind, we can probably remove that TODO.
|
You rock @MartinKavik! Thanks for taking the time to knock this out. As I mentioned elsewhere, I'll go ahead and fix the error chain display issue, and then cut a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes #82