Migrate from Axios to fetch #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk26
reviewed
Oct 4, 2022
tk26
reviewed
Oct 4, 2022
tk26
approved these changes
Oct 11, 2022
scarney81
reviewed
Oct 11, 2022
…er-node-migrate-from-axios-to
tk26
approved these changes
Oct 12, 2022
vahnag
commented
Oct 12, 2022
|
|
||
| import { HttpMethodClient, IHttpClient, IInitHttpClientOptions } from "./types"; | ||
|
|
||
| const fetch = globalThis.fetch ?? crossFetch; |
There was a problem hiding this comment.
This issue prevents cross-fetch to fall back to the existing global fetch implementation in Cloudflare workers, so I'm doing it manually.
tk26
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is pretty much still work-in-progress as there are some rough edges with the code quality that I'm going to improve before it's ready to be merged.
But I'd like to hear your thoughts about the overall solution.
Type of change
Related issues
https://linear.app/trycourier/issue/C-7120/courier-node-migrate-from-axios-to-native-fetch
Checklists
Development
Code review