Skip to content

Commit

Permalink
Merge pull request #210 from umairraza96/fix/inconsistent-module
Browse files Browse the repository at this point in the history
fix:  inconsistent case for "module" field in node bases #209
  • Loading branch information
orta authored Aug 21, 2023
2 parents 53d80ed + d73fed1 commit 5b6eb1d
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 9 deletions.
8 changes: 3 additions & 5 deletions bases/node-lts.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@
"display": "Node LTS",
"_version": "18.1.0",
"compilerOptions": {
"lib": [
"es2023"
],
"module": "Node16",
"lib": ["es2023"],
"module": "node16",
"target": "es2022",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "node16"
}
}
}
2 changes: 1 addition & 1 deletion bases/node16.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

"compilerOptions": {
"lib": ["es2021"],
"module": "Node16",
"module": "node16",
"target": "es2021",

"strict": true,
Expand Down
2 changes: 1 addition & 1 deletion bases/node17.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"_version": "17.1.0",
"compilerOptions": {
"lib": ["es2022"],
"module": "Node16",
"module": "node16",
"target": "es2022",

"strict": true,
Expand Down
2 changes: 1 addition & 1 deletion bases/node18.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

"compilerOptions": {
"lib": ["es2023"],
"module": "Node16",
"module": "node16",
"target": "es2022",

"strict": true,
Expand Down
2 changes: 1 addition & 1 deletion bases/node20.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

"compilerOptions": {
"lib": ["es2023"],
"module": "Node16",
"module": "node16",
"target": "es2022",

"strict": true,
Expand Down

0 comments on commit 5b6eb1d

Please sign in to comment.