Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Ava by Vitest #180

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Replace Ava by Vitest #180

wants to merge 23 commits into from

Conversation

skarab42
Copy link
Contributor

Motivation: #175

  • Reduce the time of the tests by half.
  • No need to copy fixtures folder to dist folder.
  • Watch mode and coverage.

tsd-vitest

@skarab42 skarab42 marked this pull request as draft March 12, 2023 18:31
@tommy-mitchell
Copy link
Contributor

Would this allow to build in watch mode, too?

@skarab42
Copy link
Contributor Author

Would this allow to build in watch mode, too?

Yes, but it need a small modification for the chmod, I'll do that tomorrow.

@sindresorhus
Copy link
Collaborator

I think this should have been discussed in an issue first.

@sindresorhus
Copy link
Collaborator

Using ts-node could probably have achieved the same thing in a few lines of code without rewriting everything.

@sindresorhus
Copy link
Collaborator

My concern with switching test runner is that most test runners do too much, which means a lot of bugs. I personally saw this when Jest became popular. It solved a lot of real use-cases true, but it also caused a lot of annoyance by being super buggy. I generally prefer simplicity. However, this is not my repo, so I'm not the one you have to convince.

@skarab42
Copy link
Contributor Author

I think this should have been discussed in an issue first.

It's not a big deal, I had fun doing it, do what you want with it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants