Fix #4461 HttpOutput Aggregation (#4466) #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Issue #4461 HttpOutput Aggregation Added tests to check that aggregation continues after first flush of an aggregated buffer (this triggers both #4461 and the discovered bug of not aggregating because of empty at capacity aggregate buffer). Added getAggregateSize method that does a compact to avoid empty at capacity aggregate buffer Call onWriteComplete if residue of an overflow aggregation can itself be aggregated. Signed-off-by: Greg Wilkins <[email protected]> * Issue #4461 HttpOutput Aggregation Removed implicit compact from GzipHandler Signed-off-by: Greg Wilkins <[email protected]> * Issue #4461 HttpOutput Aggregation Improve test coverage Signed-off-by: Greg Wilkins <[email protected]> * Issue #4461 HttpOutput Aggregation Remove case that can never happen. Signed-off-by: Greg Wilkins <[email protected]> * Issue #4461 HttpOutput Aggregation updates from review Signed-off-by: Greg Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to check that aggregation continues after first flush of an aggregated buffer (this triggers both jetty#4461 and the discovered bug of not aggregating because of empty at capacity aggregate buffer).
Added getAggregateSize method that does a compact to avoid empty at capacity aggregate buffer
Call onWriteComplete if residue of an overflow aggregation can itself be aggregated.
Signed-off-by: Greg Wilkins [email protected]
Removed implicit compact from GzipHandler
Signed-off-by: Greg Wilkins [email protected]
Improve test coverage
Signed-off-by: Greg Wilkins [email protected]
Remove case that can never happen.
Signed-off-by: Greg Wilkins [email protected]
updates from review
Signed-off-by: Greg Wilkins [email protected]