-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Conda-Forge's CSPICE Package in Tudat #225
base: develop
Are you sure you want to change the base?
Use Conda-Forge's CSPICE Package in Tudat #225
Conversation
This change ensures that changes in any CMake or CMakeLists.txt files properly invalidate the cache, preventing issues where updates to these files would not trigger a cache update, leading to failed builds.
This works locally on my macbook so I'm not sure why it's failing on mac. Some of the failures seemed to suggest that the mac build was working with the wrong CMake files, but it doesn't seem to have been loading from the wrong build cache. Local:
@niketagrawal maybe you might have an opinion given you authored the |
Sounds great! Before merging this into develop, I think it's also crucial to test if all the builds on Azure of both tudat and tudatpy are still successful. When they are, I think this is great! Listing required tasks before merging:
|
Please review and merge, @DominicDirkx. With this update, we will no longer need to maintain our own
cspice
fork and can instead utilize the peer-reviewed package maintained by astrojuanlu and AndrewAnnex available at conda-forge/cspice-feedstock. This change is long overdue. Re-rendering our owncspice
was causing issues, and switching to theconda-forge
package has proven to be a much faster and more sustainable solution.Testing Procedure
I followed these steps to ensure that the integration of the conda-forge
cspice
package works correctly with Tudat:Created a new conda environment using the
environment.yaml
provided in the Tudat repository.Set up the build directory and configured the project using CMake:
Built the specific test target and ran it using
ctest
:cmake --build . --target test_spice_SpiceInterface ctest -R test_spice_SpiceInterface
Test Results:
These results confirm that the
cspice
library from conda-forge is compatible with our current Tudat setup and meets all our requirements. This switch should simplify our dependencies and reduce maintenance overhead.