Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable ROI margin #46

Merged
merged 6 commits into from
Feb 23, 2023
Merged

Add configurable ROI margin #46

merged 6 commits into from
Feb 23, 2023

Conversation

MatthijsBurgh
Copy link
Member

No description provided.

@MatthijsBurgh
Use ref when possible
f627984
@MatthijsBurgh
Use c++11 for loops
7e8ed54
@MatthijsBurgh
Fix ROI bounds
d6407fb
@MatthijsBurgh
Use cv::Point instead of cv::Point2i
3a93cff
@MatthijsBurgh
Also be robust for negative roi_margin
b3ceeb9 
A negative roi_margin reduces the roi. This can move the origin of the roi outside the image or increase the size to much.
@MatthijsBurgh MatthijsBurgh marked this pull request as ready for review January 30, 2023 14:51
@MatthijsBurgh MatthijsBurgh mentioned this pull request Jan 30, 2023
Open
@MatthijsBurgh
Copy link
Member Author

@PetervDooren please check my responses to your questions

@MatthijsBurgh MatthijsBurgh merged commit 28e825a into master Feb 23, 2023
@MatthijsBurgh MatthijsBurgh deleted the lotte branch February 23, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetervDooren PetervDooren PetervDooren approved these changes

@lottemessing lottemessing Awaiting requested review from lottemessing

Assignees

@lottemessing lottemessing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthijsBurgh @PetervDooren @lottemessing