Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish Translation #80

Merged
merged 6 commits into from
Dec 14, 2019
Merged

Spanish Translation #80

merged 6 commits into from
Dec 14, 2019

Conversation

FluffyHyena
Copy link
Contributor

Added a Spanish translation both to the widgets and the menu, but can't test if it works as I don't have the means to compile the app. I hope it's ok!

FluffyHyena added 3 commits December 1, 2019 21:10
Added a Spanish translation
Added Spanish language to arrays
@tuur29
Copy link
Owner

tuur29 commented Dec 2, 2019

Thanks a lot! 🙂

On first glance it all looks fine, I'll test it as soon as possible and send you some screenshots to review, once everything looks good I'll merge this.

@tuur29
Copy link
Owner

tuur29 commented Dec 2, 2019

I've run the app everything seems to work fine, but it seems like you (and I) forgot to add a few things:

  • make sure all the pref_list_language_titles lists (x3) have a "Spanish" value (not manually selectable otherwise), keep in mind that the order should be the same everywhere (same as pref_list_language_values in arrays.xml). You can use "Spaans" as a Dutch/NL translation.
  • The label "Visible" doesn't seem to be translated, or perhaps this is the same as English? (See screenshot).
  • Could you add a comment in this PR with Spanish values for pref_list_fontFamilyLimited_titles and pref_list_emphasis_titles? It seems I've defined them in the wrong place and because of it they are currently not translatable. If you'd be so kind to translate them here in a comment, I'll add them at a later date when I fix this.

This is some test output for you to check:

00:00 -> docey cinco 
00:01 -> docey cinco 
01:03 -> unay cinco 
02:05 -> dosy cinco 
03:07 -> tresy diez 
04:10 -> cuatroy diez 
05:14 -> cincoy cuarto 
06:15 -> seisy cuarto 
07:16 -> sietey veinte 
08:20 -> ochoy veinte 
09:29 -> nuevey media 
09:30 -> nuevey media 
09:31 -> nuevemenos veinticinco 
09:35 -> diezmenos veinticinco 
09:36 -> diezmenos veinte 
10:41 -> oncemenos cuarto 
11:50 -> docemenos diez 
12:53 -> unamenos cinco 
12:55 -> unamenos cinco 
13:57 -> dos
14:59 -> tres
15:00 -> tresy cinco 
23:50 -> docemenos diez 

And some screenshots:

Screenshot_20191202-221110

Screenshot_20191202-221115

Screenshot_20191202-221123

Time was 22:15:
Screenshot_20191202-221512

Thanks again!

FluffyHyena added 3 commits December 2, 2019 19:46
Also removed any changes to base code and fixed a bug with the Spanish code
@FluffyHyena
Copy link
Contributor Author

Ok! In this order:

  • Woops! Fixed! It should be alright now, thank you!

  • Visible is the same in both languages! It was like "time to edit this! Oh wait, it doesn't need to be edited"

  • Sure thing! Fortunately we use the same names for fonts than English, but the names for the emphasis are, in this order: Normal, Negrita, Cursiva, Negrita Cursiva. Hope that helps!

Also I just fixed an error in the display where I forgot to move the space string between the hour and minute string and I went and made the minutes more like the base English code rather than adding/removing anything sooo it should be ok now! Let me know of anything else!

@tuur29 tuur29 merged commit dc7d525 into tuur29:master Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants