-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsass miscompiles breadcrumb content #919
Comments
Thanks for looking into this. I am experiencing this issue. |
(b) One work around is to define $ echo 'a { $a: "/"; $b: "\00a0"; x: "#{$a}#{$b}" }' | node-sass
@charset "UTF-8";
a {
x: "/ "; } (a) Since the workaround is easy, I'll add it in for the time being. Note that the UTF-8 encoding causes #803 for IE 10/11 when other non-UTF8 CSS files are concatenated incorrectly, though that is something we decided not to deal with. |
As this issue is completely libsass-specific, it seems logical to keep it downstream, IMO. |
This has been fixed on |
Can you please update composer module https://packagist.org/packages/twbs/bootstrap-sass to latest version with this fix. now it is only:
|
@klierik We have yet to ship a new release version since the fix was merged. Please be patient. The Composer package isn't any more outdated than our other packages. Thanks. |
bootstrap-sass is pointing to github while we are awaiting a fix to a sass bug (twbs/bootstrap-sass#919)
@cvrebert Looking at the 3.3.6 milestone for Bootstrap it seems like it won't be ready soon. Any chance you could cut release with this fix before the upstream release? |
@realityking Temporary workaround:
|
@xKairu Lifesaver. Thank you. |
Work around for sass/libsass#1115
This is due to using node-sass instead of Ruby compass. The header trail shows  instead of /. See: twbs/bootstrap-sass#919
This is due to using node-sass instead of Ruby compass. The header trail shows  instead of /. See: twbs/bootstrap-sass#919
This is due to using node-sass instead of Ruby compass. The header trail shows  instead of /. See: twbs/bootstrap-sass#919
Under the environment:
the SCSS in question:
is getting compiled to:
which is incorrect.
By comparison, Ruby Sass compiles this code to:
which is correct (albeit not ASCII).
This is due to a bug in libsass: sass/libsass#1115
The questions are (a) should bootstrap-sass try to workaround this? (b) if yes, how? (c) if yes, since this only affects libsass, do we make the change in bootstrap-sass, or in upstream Bootstrap?
CC: @twbs/sass
The text was updated successfully, but these errors were encountered: