Skip to content

Commit

Permalink
Fixes #13003: Move padding on radio and checkbox options from the sur…
Browse files Browse the repository at this point in the history
…rounding div to the label to remove the no-click deadzone caused by negative margin
  • Loading branch information
mdo committed Mar 10, 2014
1 parent ac8db90 commit a83ca38
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 13 deletions.
4 changes: 2 additions & 2 deletions dist/css/bootstrap-rtl.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/css/bootstrap-rtl.min.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/css/bootstrap.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/css/bootstrap.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/css/bootstrap.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/assets/js/customize.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/dist/css/bootstrap-rtl.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/dist/css/bootstrap.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/dist/css/bootstrap.min.css

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions less/forms.less
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,11 @@ input[type="date"] {
min-height: @line-height-computed; // clear the floating input if there is no label text
margin-top: 10px;
margin-bottom: 10px;
padding-left: 20px;

label {
display: inline;
// display: inline;

This comment has been minimized.

Copy link
@rinatio

rinatio May 14, 2014

Hi @mdo, I'm not sure if that's intentional or not, but without display: inline checkboxes have a big gap between each other, like here in chrome 34.0.1847.131 on os x.
screen shot 2014-05-14 at 4 44 10 pm

This comment has been minimized.

Copy link
@cvrebert

cvrebert May 14, 2014

Collaborator

@rinatio You're perhaps encountering #13548?

This comment has been minimized.

Copy link
@rinatio

rinatio May 15, 2014

@cvrebert right, seems like the same issue, removing line breaks helps too. Can reproduce it in chrome only, weird

padding-left: 20px;
margin-bottom: 0;
font-weight: normal;
cursor: pointer;
}
Expand Down

2 comments on commit a83ca38

@kibao
Copy link

@kibao kibao commented on a83ca38 May 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdo your fix doesn't update padding for .inline-form, so there's unneeded padding on radio & checkbox label.
http://jsfiddle.net/DEuud/
edit fiddle - jsfiddle 2014-05-22 21-29-42

@cvrebert
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kibao Please file an issue.

Please sign in to comment.