noConflict() still not working in 3.0.x

[colllin]

http://jsfiddle.net/colllin/jZUbB/

Unless I'm using it incorrectly... sorry for the bad news :)

[colllin]

Something along these lines might do the trick:
colllin@79d1c18

All I'm doing is defining the plugin function earlier on. That way I can reference it directly and .apply() it where I need it instead of trying to reference $().tooltip() (which no longer exists in noConflict mode).

[cvrebert]

tooltip and tab plugins' noConflict features claimed to be broken so far.

[fat]

@colllin - nice! but function's are hoisted, so no need to move it up in code like that if you do function Plugin() that way we can keep that code consistent across the plugins

[colllin]

Modal plugin is affected:

bootstrap/js/modal.js

Line 236 in 6a42305

.modal(option, this)

Scrollspy plugin is affected:

bootstrap/js/scrollspy.js

Line 154 in 7545da2

$spy.scrollspy($spy.data())

Affix plugin is affected:

bootstrap/js/affix.js

Line 122 in 6a42305

$spy.affix(data)

Button plugin is affected:

bootstrap/js/button.js

Line 111 in 5d6e921

$btn.button('toggle')

Collapse plugin is affected:

bootstrap/js/collapse.js

Line 56 in 6a42305

actives.collapse('hide')

bootstrap/js/collapse.js

Line 176 in 6a42305

$target.collapse(option)

Carousel plugin is affected:

bootstrap/js/carousel.js

Line 201 in 6a42305

$target.carousel(options)

bootstrap/js/carousel.js

Line 213 in 6a42305

$carousel.carousel($carousel.data())

These are the obvious ones -- found by searching for .carousel(, etc. The original dropdown one I sent over was a more obscure reference to $.fn.dropdown so it might take someone reading the code in depth to find more of those, or maybe search for ]( to find any other variable function names that are being used and rule them out one-by-one.

So far: tooltip, tab, modal, scrollspy, affix, button, collapse, carousel claimed to be broken.

[colllin]

I was thinking about writing tests for this. It seems like I have to decide between two strategies. The easiest is probably to run all tests in noConflict mode, with some global reference (window.affixPlugin) to the original plugin, and rewrite all existing tests to use that global reference. The other option is to rewrite all tests to accept a passed-in reference to the plugin, and then run all tests once normally then again in noConflict mode.

Would this be valuable or would you rather that I just spend the time fixing the plugins?

[fat]

@colllin could you open a pull request when you get this in a good spot? thanks!

[colllin]

Sorry - I did. But I couldn't figure out how to attach it directly to this issue. #11966

[cvrebert]

Closing in favor of your pull request.