Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel: indicators - enable possibility to swap .active class #12592

Closed
SimonHarte opened this issue Feb 5, 2014 · 4 comments · Fixed by #13770
Closed

Carousel: indicators - enable possibility to swap .active class #12592

SimonHarte opened this issue Feb 5, 2014 · 4 comments · Fixed by #13770
Labels
Milestone

Comments

@SimonHarte
Copy link

It would be nice if there could be an option to "swap" active classes instead of having no .active during transitions or add a .sliding class or something similar. Currently an active item loses its class as soon as the transition starts and the new item gets the active class when transition stops, so there is a timespan where none of the indicators is active.

@cvrebert cvrebert added the js label Feb 5, 2014
@cvrebert cvrebert added this to the v3.1.1 milestone Feb 5, 2014
@lalitkapoor
Copy link

would it be better if the active class is swapped once the transition has completed?

@SimonHarte
Copy link
Author

Imho yes, I have a case where I only show the active Indicator, so during transition none is visible. Don't know if it's worth an option but I don't want you to just make this a default, as most other users of carousel might expect the current behavior.

@cvrebert cvrebert modified the milestones: v3.2.0, v3.1.1 Feb 9, 2014
@SimonHarte
Copy link
Author

Is there something planned concerning this issue?

@cvrebert
Copy link
Collaborator

If there was, you'd see it here.

fat added a commit that referenced this issue Jun 10, 2014
change how carousel indicators activate - fixes #12592
@mdo mdo modified the milestones: v3.2.1, v3.2.0 Jun 10, 2014
@mdo mdo mentioned this issue Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants