Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.btn-link in .navbar-inverse is not white #12694

Closed
Wolfr opened this issue Feb 11, 2014 · 3 comments
Closed

.btn-link in .navbar-inverse is not white #12694

Wolfr opened this issue Feb 11, 2014 · 3 comments

Comments

@Wolfr
Copy link

Wolfr commented Feb 11, 2014

http://jsfiddle.net/QArP2/

Since there are the defaults for navbar-inverse are these one would expect the .btn-link to be $gray-light (the code works for regular links but not for .btn-links).

$navbar-inverse-link-color:                 $gray-light !default;
$navbar-inverse-link-hover-color:           #fff !default;
$navbar-inverse-link-hover-bg:              transparent !default;
@cvrebert cvrebert added this to the v3.2.0 milestone Feb 11, 2014
@supergibbs
Copy link
Contributor

A couple comments.

  • The .btn-toolbar isn't meant for a .navbar. Use .navbar-btn OR wrap in a .navbar-form
  • Usually .btn-link is used on a button element to make a button look like a link. There are some cases where you'd use in on a a tag but you can just use .navbar-link and forgo the .btn and .btn-link classes in most cases.
  • In the case of a button.btn.btn-link in a navbar you can also add .navbar-link to get the correct colors.

I've updated your example to show this: http://jsfiddle.net/Supergibbs/mNgR6/

I agree it'd be nice to be able to use .btn-link in a .navbar-inverse and have the colors match without having to use btn btn-link navbar-link or even worse btn navbar-btn btn-link navbar-link

I'll take stab at that 😄

@supergibbs
Copy link
Contributor

Working example:

http://jsfiddle.net/Supergibbs/3urAJ/

@mdo
Copy link
Member

mdo commented Mar 7, 2014

Fixed via #12813.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants