.dl-horizontal with empty <dd> is not working

[dairiki]

The &:extend(.clearfix all) on .dl-horizontal dd (line 209 of type.less) does not seem to be working. I.e. the dds are not getting clearfixed, with the result that if a <dd> is empty, the <dd>s from the subsequent row will move up, being displayed in place of the empty <dd>.

This appears to have become an issue with 3.1.0 when .clearfix() was replaced with &:extend(.clearfix all) (in 0016c17).
(Perhaps this, at its root, is a lessc bug having to do with extends within media queries?)

A demo of the problem is at http://jsbin.com/codam/1. (Note that bar def should be displayed on the same "row" as Bar, but instead it is displayed next to Foo.)

Updated: Fixed link to commit 0016c17

[hnrch02]

Yeah, it looks like it is a LESS bug, as this example works perfectly fine.

[dairiki]

Upon further reading of the LESS docs, this looks to be a documented behavior of lessc. See Scoping / Extend Inside @media where it says “Extend written inside a media declaration should match only selectors inside the same media declaration”.

So lessc is behaving correctly; this is a bootstrap bug.

One fix would be to revert the &:extend(.clearfix all) back to the old-fashioned .clearfix() in this one case.

[hnrch02]

Ah, I see, should've at least flipped through the LESS documentation 😄
Your proposed solution sounds good, are you planning on opening a PR?

[dairiki]

Ah, I see, should've at least flipped through the LESS documentation

Yes, so should”ve I, before filing the initial ticket!

Sure. I'll create a PR.

[dairiki]

PR #12756 created.

[dairiki]

Fixed in b99be29. Closing.

[mdo]

<3 thanks!

[cvrebert]

(Note for self and future readers: None of the other clearfix inclusions that were changed to use extend were inside media queries, so no need to worry about other components in that commit being affected by the same problem.)