bower.json: ignore test-infra?

[zlatanvasovic]

test-infra/ is not useful for our Bower package, so should it be ignored?

[cvrebert]

The problem is that the Gruntfile reads test-infra/sauce_browsers.yml.

[zlatanvasovic]

Not by default. Only if you change $TWBS_TEST you'll get errors.

🚶 🔛 🌔

[cvrebert]

Yes by default. Try deleting it and then running grunt dist, and you'll see.

[zlatanvasovic]

Okay then. Do you want to ignore it with !<path> or just move it to grunt, or whatever? :D

It's pretty confusing when you have many files.

[cvrebert]

I guess /grunt/ is the least-worse option.

[zlatanvasovic]

🍭

@XhmikosR Any thoughts?

[XhmikosR]

I'm not sure I get the problem here. Why does it matter if we have the test-infra folder like we do now?

[zlatanvasovic]

Because it isn't required for Bower package. Bower package should be as
small as possible so downloads get fast.

2014-03-16 4:46 GMT+01:00 XhmikosR [email protected]:

I'm not sure I get the problem here. Why does it matter if we have the
test-infra folder like we do now?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/13065#issuecomment-37747923
.

Zlatan Vasović - ZDroid

[XhmikosR]

I agree with that but then you have people wondering why some files are missing. :/

If one needs to develop they should check out the source. And by even including Gruntfile, I don't think that's clear.

Anyway, I can't really comment on this; Chris is the person who can make this decision better than me.

[mdo]

Punting until a better solution is proposed. Sounds like from this and another issue or two that we might want to rearrange some things. I defer to @cvrebert.

[cvrebert]

We'll just move the file into /grunt/ like I suggested. We can then exclude /test-infra/ from Bower entirely.

[mdo]

Shit, sorry, missed that <3.