-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make fonts always relative to project.less is not good idea #13478
Comments
Technically, the icon font path is currently relative to the location of the generated CSS file. |
@cvrebert yes, and that is why i veto to the change, because it makes use of bootstrap really inconvenient, everytime a new .css is generated I have to copy over the fonts to sit aside. |
still that require changing the
maybe bootstrap has its own reason to stay as it is now, if you insist, i will close the issue, thx. |
One complicating factor is that some Bower tools reorganize Bootstrap's directory structure, which can break relative path references. |
…e same variable, we should do the same thing for the time being. However let's keep an eye on issue twbs#13478, see if they change this.
👍 for reverting the "fix". Revert: sokra@88b3032 You'll need relative urls when |
Nice! 👍 |
veto to #10941 , the guy report the issue must because he is compiling with
--relative-urls
turned on, that's why fonts folder are relative to bootstrap.lesswhether or not relative should be controlled by lessc parameter
--relative-urls
not by hard coding it.it would be actually good idea to make sure fonts are relative to bootstrap.less (when --relative-urls is used) as i don't have to copy over the fonts from bower folder to project folder, a simple
bower install
should do the job.@jhnns also mentioned that the change cause
rootpath
options useless in the thread of #10941 .The text was updated successfully, but these errors were encountered: