Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding left 20px on .checkbox is gone? #13591

Closed
JelmerD opened this issue May 13, 2014 · 7 comments
Closed

Padding left 20px on .checkbox is gone? #13591

JelmerD opened this issue May 13, 2014 · 7 comments
Labels

Comments

@JelmerD
Copy link

JelmerD commented May 13, 2014

When I have a look at http://getbootstrap.com/css/#forms, in particular the checkbox you see over there (element inspector) I notice that .checkbox has padding-left: 20px;.

Where does it come from? Because looking at the less files in the repo tell me there is no padding-left of 20px on this element. Ctrl+f on the forms.less gives me 3 "padding-left" matches, non of which ...

I would have expected it over here comparing it with the other styles applied on the same .checkbox class: https://github.com/twbs/bootstrap/blob/master/less/forms.less#L211 but it's not there. Looking at the blame log doesn't help me either.

Thiis kinda breaks a form in my project. Any ideas if this did go missing by accident?

@JelmerD
Copy link
Author

JelmerD commented May 13, 2014

Actually, I suspect this line: https://github.com/twbs/bootstrap/blob/master/less/forms.less#L212
Should have been & label instead of label

@hnrch02
Copy link
Collaborator

hnrch02 commented May 13, 2014

This change was introduced in a83ca38 to fix #13003. You are using the bleeding-edge code from master and not v3.1.1, correct?

@JelmerD
Copy link
Author

JelmerD commented May 13, 2014

@hnrch02 that is correct. I will update to 3.1.1 right away and test if that solves it.

@hnrch02
Copy link
Collaborator

hnrch02 commented May 13, 2014

Also, could get into more detail about how this breaks your project? http://jsbin.com/yenidi/1/edit works fine, maybe there's a problem with the markup you are using?

@JelmerD
Copy link
Author

JelmerD commented May 13, 2014

@hnrch02 of course that one works, because that version actually HAS the padding-left 😉 on the label. My label and/or checkbox does not. Causing my checkbox to be -20px off. So it's not visible :)

@hnrch02
Copy link
Collaborator

hnrch02 commented May 13, 2014

It uses the latest compiled version of Bootstrap available on master, so the problem you are describing isn't currently happening when using a clean version.

@JelmerD
Copy link
Author

JelmerD commented May 13, 2014

@hnrch02 Updating to 3.1.1 solved it. Thanks.

@JelmerD JelmerD closed this as completed May 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants