Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Remember me" checkbox in Sign In example is horizontally misaligned #13964

Closed
cvrebert opened this issue Jun 27, 2014 · 5 comments · Fixed by #13993
Closed

"Remember me" checkbox in Sign In example is horizontally misaligned #13964

cvrebert opened this issue Jun 27, 2014 · 5 comments · Fixed by #13993

Comments

@cvrebert
Copy link
Collaborator

http://getbootstrap.com/examples/signin/

@XhmikosR
Copy link
Member

@cvrebert: see this patch and let me know

 docs/examples/signin/index.html | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/docs/examples/signin/index.html b/docs/examples/signin/index.html
index c9d2293..80ff1c9 100644
--- a/docs/examples/signin/index.html
+++ b/docs/examples/signin/index.html
@@ -36,12 +36,16 @@

       <form class="form-signin" role="form">
         <h2 class="form-signin-heading">Please sign in</h2>
-        <input type="email" class="form-control" placeholder="Email address" required autofocus>
-        <input type="password" class="form-control" placeholder="Password" required>
-        <label class="checkbox">
-          <input type="checkbox" value="remember-me"> Remember me
-        </label>
-        <button class="btn btn-lg btn-primary btn-block" type="submit">Sign in</button>
+        <div class="form-group">
+          <input type="email" class="form-control" placeholder="Email address" required autofocus>
+          <input type="password" class="form-control" placeholder="Password" required>
+          <div class="col-sm-offset-1">
+            <label class="checkbox">
+              <input type="checkbox" value="remember-me"> Remember me
+            </label>
+          </div>
+          <button class="btn btn-lg btn-primary btn-block" type="submit">Sign in</button>
+        </div>
       </form>

     </div> <!-- /container -->

@XhmikosR
Copy link
Member

Nah, needs a better solution.

cvrebert added a commit that referenced this issue Jun 30, 2014
@cvrebert cvrebert mentioned this issue Jun 30, 2014
mdo added a commit that referenced this issue Jun 30, 2014
@MohammadYounes
Copy link
Contributor

As of 3.2 the "Remember me" checkbox in Sign In example is horizontally misaligned again!

@hnrch02
Copy link
Collaborator

hnrch02 commented Sep 3, 2014

@MohammadYounes This fix hasn't shipped yet. It will be included in the upcoming version 3.2.1.

@MohammadYounes
Copy link
Contributor

@hnrch02 Thanks, I didn't notice as the issue wasn't re-opened.

According to d10c295eef4b599e62baf89358b2043a6ee4b403, now its required to wrap checkboxes inside <div class="checkbox">...</div>

@twbs twbs locked and limited conversation to collaborators Sep 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants