Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center align helper improvement #143

Closed
ianstormtaylor opened this issue Sep 2, 2011 · 3 comments
Closed

Center align helper improvement #143

ianstormtaylor opened this issue Sep 2, 2011 · 3 comments
Milestone

Comments

@ianstormtaylor
Copy link

Probably better to make:

margin: 0 auto;

into:

margin-right: auto; margin-left: auto;

to allow it to not overwrite other things?

Although you might argue that it should always be listed first, and the current setup enforces that.

@mdo
Copy link
Member

mdo commented Sep 3, 2011

That's a good idea actually. No need to zero out the top/bottom margins unnecessarily here. I've added this to the 1.3-wip branch and fixed it there.

@mdo mdo closed this as completed Sep 3, 2011
@katanacrimson
Copy link

For what it's worth, couldn't this be shortened to margin: inherit auto; instead? it'd save a bit of code and should have the same effect.

@katanacrimson
Copy link

Nevermind that. I'm an idiot. >///<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants