Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked progress bar is incompatible with aria-valuenow=0 #14736

Closed
chrisirhc opened this issue Oct 6, 2014 · 5 comments
Closed

Stacked progress bar is incompatible with aria-valuenow=0 #14736

chrisirhc opened this issue Oct 6, 2014 · 5 comments
Labels
Milestone

Comments

@chrisirhc
Copy link

When using stacked progress bars, the value 0 is not usable with the aria-valuenow attribute.

See:
http://plnkr.co/edit/MqKBgSEWHidDY6lNFWwG?p=preview

This is due to the min-width for the [aria-valuenow=0] pushing the 100% bar element to the next line.

Discovered while testing angular-ui/bootstrap#2511 .

@twbs-lmvtfy
Copy link

Hi @chrisirhc!

You appear to have posted a live example (http://run.plnkr.co/plunks/MqKBgSEWHidDY6lNFWwG/), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

  • line 22, column 28: Element div is missing one or more of the following attributes: aria-orientation, role.
  • line 34, column 28: Element div is missing one or more of the following attributes: aria-orientation, aria-valuenow, role.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

@chrisirhc
Copy link
Author

The validation errors are intentional as mentioned above.

@cvrebert cvrebert added the css label Oct 6, 2014
@cvrebert
Copy link
Collaborator

cvrebert commented Oct 6, 2014

Refs #12848.

@hnrch02
Copy link
Collaborator

hnrch02 commented Oct 6, 2014

Duplicate of #14586.

@mdo
Copy link
Member

mdo commented Oct 6, 2014

Ugh, yeah, probably have to remove that, too.

@mdo mdo added this to the v3.2.1 milestone Oct 6, 2014
@mdo mdo closed this as completed in 2c2564f Oct 26, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants