Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permalink on hover in docs headers #14897

Closed
XhmikosR opened this issue Oct 28, 2014 · 9 comments · Fixed by #15491
Closed

Add permalink on hover in docs headers #14897

XhmikosR opened this issue Oct 28, 2014 · 9 comments · Fixed by #15491
Labels

Comments

@XhmikosR
Copy link
Member

Since the headers already have IDs it only makes sense to have a permalink button available.

We could do it quickly with JS without changing the markup. I can make a PR soon if needed.

A nice addition would be to have it paired with ZeroClipboard.

/CC @twbs/team

@XhmikosR XhmikosR added the docs label Oct 28, 2014
@mdo
Copy link
Member

mdo commented Oct 28, 2014

I'm using something on my site right now that does that: http://markdotto.com/2014/09/25/sass-and-jekyll/. Would like to see it added to the docs if it's minimal enough.

@cvrebert cvrebert added this to the v3.3.1 milestone Oct 28, 2014
@XhmikosR
Copy link
Member Author

OK I will check your solution too and make a PR.
On Oct 28, 2014 8:26 PM, "Mark Otto" [email protected] wrote:

I'm using something on my site right now that does that:
http://markdotto.com/2014/09/25/sass-and-jekyll/. Would like to see it
added to the docs if it's minimal enough.


Reply to this email directly or view it on GitHub
#14897 (comment).

@hnrch02 hnrch02 removed this from the v3.3.1 milestone Nov 11, 2014
@cvrebert
Copy link
Collaborator

cvrebert commented Dec 1, 2014

👍

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 1, 2014

Has taken me some time, but I'll get to it at some point. In the meantime, I have pushed a WIP of the JS way which I don't really like. I just wanted to push what I had locally before I try the CSS only approach.

@mdo
Copy link
Member

mdo commented Dec 1, 2014

We could wait for this to come in v4, too. Not a huge rush since folks can get this with the side nav currently (though it's not as intuitive).

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 1, 2014

^^plus hidden on mobile ;)

I'll get to it, it's no big deal. I just have a few stuff on my plate I need to sort first.

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 9, 2014

@mdo: so you still want to go with your pure CSS solution? I'm all for that too, but I'm not sure how we'll be able to do it without editing the HTML files to add the class.

@mdo
Copy link
Member

mdo commented Dec 11, 2014

@XhmikosR The solution on my site has a JS file and uses just a tad bit of CSS to style the inserted HTML element on hover.

@XhmikosR
Copy link
Member Author

Ah, all right then, so it's similar to the way I have already done it.

I'll try to finish this this weekend <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants