Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences in margin (top and bottom) on dropdown-menus. #15148

Closed
vsn4ik opened this issue Nov 16, 2014 · 1 comment
Closed

Differences in margin (top and bottom) on dropdown-menus. #15148

vsn4ik opened this issue Nov 16, 2014 · 1 comment
Labels
Milestone

Comments

@vsn4ik
Copy link
Contributor

vsn4ik commented Nov 16, 2014

  • .dropdown-menu (margin-top: 2px - *1) and .dropup .dropdown-menu (margin-bottom: 1px - *2) not equal.
  • .navbar-nav > li > .dropdown-menu (margin-top: 0px - *3) and .navbar-fixed-bottom .dropdown .dropdown-menu (margin-bottom: 1px - *2) not equal.

*1: https://github.com/twbs/bootstrap/blob/master/less/dropdowns.less#L38.
*2: https://github.com/twbs/bootstrap/blob/master/less/dropdowns.less#L193.
*3: https://github.com/twbs/bootstrap/blob/master/less/navbar.less#L329

@cvrebert cvrebert added the css label Nov 16, 2014
@mdo
Copy link
Member

mdo commented Nov 21, 2014

The dropdowns and dropups should likely have the same value for top and bottom, respectively, but the navbar is purposely overridden to be attached to the navbar.

@mdo mdo added this to the v3.3.2 milestone Nov 30, 2014
@mdo mdo closed this as completed in c22b8dc Nov 30, 2014
mdo added a commit that referenced this issue Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants